order realized VM results by external_id #1194
Conversation
|
@paulzerkel, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
This PR adds external_id as the sortByParam for calls to the realized VM endpoint. This is needed in larger environments (1k+ VMs) because as of NSX-T 3.2.3 the /policy/api/v1/infra/realized-state/virtual-machines endpoint is not respecting a consistent ordering by default. This means that the internal slice representing VMs returned from listAllPolicyVirtualMachines may include duplicates and may be missing VMs that actually exist. Explicitly setting an order forces consistent results across the paginated calls. Resolves: vmware#1193 Signed-off-by: Paul Zerkel <[email protected]>
paulzerkel
force-pushed
the
order-listAllPolicyVirtualMachines
branch
from
e7a0b6e to
f54e7a2
Compare
|
/test-all |
|
Thank you @paulzerkel, merging this. |
|
Thanks for the heads up on the new functionality, @annakhm ! That will be a great improvement once we get to that version of NSX-T. |
This PR adds external_id as the sortByParam for calls to the realized VM endpoint. This is needed in larger environments (1k+ VMs) because as of NSX-T 3.2.3 the /policy/api/v1/infra/realized-state/virtual-machines endpoint is not respecting a consistent ordering by default. This means that the internal slice representing VMs returned from listAllPolicyVirtualMachines may include duplicates and may be missing VMs that actually exist. Explicitly setting an order forces consistent results across the paginated calls.
Resolves: #1193